FileUploader: Implement internal file count limitation #31500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements an internal file count limitation feature for the FileUploader component. The feature allows developers to set a maximum number of files that can be uploaded and provides a callback when this limit is reached.
Key Changes:
- Added
_maxFileCountoption to limit the number of files that can be selected - Implemented
onFileLimitReachedevent callback that fires when the file limit is exceeded - Added file count validation for both file input selection and drag-and-drop operations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/devextreme/js/__internal/ui/file_uploader/file_uploader.types.ts |
Added type definitions for FileLimitReachedEvent and the _maxFileCount and onFileLimitReached options |
packages/devextreme/js/__internal/ui/file_uploader/file_uploader.ts |
Implemented file limit validation logic, event handling, and integration with file input and drag-drop workflows |
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/fileUploader.tests.js |
Added comprehensive test coverage for the file limit feature across multiple scenarios |
packages/devextreme/js/__internal/ui/file_uploader/file_uploader.ts
Outdated
Show resolved
Hide resolved
marker-dao
force-pushed
the
25_2_fileuploader_limit_files
branch
from
3cb4bd3 to
11e53e6
Compare
added 2 commits
October 29, 2025 08:48
Zedwag
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.